Inflection-42 Rename Morphuntion to Unicode Inflection and reduce CoreFoundation dependency #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFoundation dependency
nciric
approved these changes
Jan 9, 2025
|
Could you rename paths in how-to-add-language document too? In this or separate PR. |
…eFoundation dependency
|
I'll make the change in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Issue #42.
As per the discussion in the last Inflection meeting (1/7/2025), the decision was to rename Morphuntion to the Unicode Inflection library.
There was also a decision to reduce the usage of the CoreFoundation. This change will remove the CFLocaleRef and CFErrorRef usage with the rest of the changes being handled with #36. CFLocaleRef will be switch to const char*, and CFErrorRef will switch to UErrorCode in this pull request.
This pull request built and passed the tests on macOS and Linux. Valgrind reported no memory issues. The check-headers target reported no issues.