Skip to content

Conversation

nciric
Copy link
Contributor

@nciric nciric commented Feb 11, 2025

Adding information on how to expand (or create new lexicons).

@nciric nciric requested a review from grhoten February 11, 2025 19:34

Once you upload/enter data, it may take a few days for it to show up in the regular dumps - depending on review requirements.

```python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move all of this code to a separate location outside of this document so that it can be executed and maintained separately? I can see people wanting to add additional properties that may be helpful for other languages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but I don't guarantee the code will run (it was a sample Denny sent me to help with the upload). I'll make it more generic later.

Comment on lines 5 to 7
There are two ways of adding new data to the lexicon:
1. Running [dictionary-parser](../inflection/tools/dictionary-parser/README.md) on a local file.
1. Adding data to Wikidata first, then running step 1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this wording be rephrased? It's a little confusing. This step isn't needed if there is enough data. Perhaps something like the following can be used:

When there is insufficient lexical data from Wikidata for a specific language, you may need to generate and contribute significant quantities of lexical data to Wikidata. This will ensure that the data is maintained, and others can reuse your results. After you have reviewed such data for correctness, and contributed it to Wikidata, the dictionary-parser can be used to extract the data and use for this project.

If only a few words need to be added or modified, it's recommended that you contribute those changes directly through Wikidata instead of through the tools mentioned here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@richgillam
Copy link

Looked at this, but didn't have anything useful to say.

@nciric nciric merged commit a20c60e into main Feb 11, 2025
1 check passed
@nciric nciric deleted the cira-docs branch February 11, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants