Skip to content

Conversation

milansamuel609
Copy link
Contributor

@milansamuel609 milansamuel609 commented Mar 5, 2025

@nciric I have added the macOS and Windows support. Please kindly check once.

Screenshot 2025-03-06 025345

@nciric nciric merged commit 5353626 into unicode-org:main Mar 5, 2025
1 check passed
@nciric
Copy link
Contributor

nciric commented Mar 5, 2025

nciric added a commit that referenced this pull request Mar 5, 2025
nciric added a commit that referenced this pull request Mar 5, 2025
@milansamuel609
Copy link
Contributor Author

There are errors for MacOS and Windows, see: https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346595 https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346206

Did you test it after submitting?

I am really sorry for my mistake, I have not tested it after submission. But before submission I have checked it. I will fix it sooner.

There are errors for MacOS and Windows, see: https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346595 https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346206

Did you test it after submitting?

I sincerely apologize for the oversight in my recent PR. While I did test the changes before submission, I unfortunately did not verify the final build after pushing the PR.

I truly appreciate your patience, and I will work on fixing these issues as soon as possible.

@nciric
Copy link
Contributor

nciric commented Mar 6, 2025 via email

@milansamuel609
Copy link
Contributor Author

No problem, there are couple of areas to focus on: 1. Try fixing one platform at the time, it's easier to test 2. MacOS seems easier, as it's missing a dependency (ICU). See build instructions https://github.com/unicode-org/inflection/blob/main/inflection/README.md#building on how to get it. I wonder if you have access to mac and win builds in your cloned repo? сре, 5. мар 2025. у 19:34 Milan P Samuel @.> је написао/ла:

There are errors for MacOS and Windows, see: https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346595 https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346206 Did you test it after submitting? I am really sorry for my mistake, I have not tested it after submission. But before submission I have checked it. I will fix it sooner. There are errors for MacOS and Windows, see: https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346595 https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346206 Did you test it after submitting? I sincerely apologize for the oversight in my recent PR. While I did test the changes before submission, I unfortunately did not verify the final build after pushing the PR. I truly appreciate your patience, and I will work on fixing these issues as soon as possible. — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7GEKUSXTDZ5OL5BE3LKCL2S6623AVCNFSM6AAAAABYNEG7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBSG4YDQMBSGI . You are receiving this because you modified the open/close state.Message ID: @.
> [image: milansamuel609]milansamuel609 left a comment (unicode-org/inflection#89) <#89 (comment)> There are errors for MacOS and Windows, see: https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346595 https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346206 Did you test it after submitting? I am really sorry for my mistake, I have not tested it after submission. But before submission I have checked it. I will fix it sooner. There are errors for MacOS and Windows, see: https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346595 https://github.com/unicode-org/inflection/actions/runs/13687241509/job/38273346206 Did you test it after submitting? I sincerely apologize for the oversight in my recent PR. While I did test the changes before submission, I unfortunately did not verify the final build after pushing the PR. I truly appreciate your patience, and I will work on fixing these issues as soon as possible. — Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7GEKUSXTDZ5OL5BE3LKCL2S6623AVCNFSM6AAAAABYNEG7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBSG4YDQMBSGI . You are receiving this because you modified the open/close state.Message ID: @.***>

I have fixed the macOS support. Now currently trying to fix the windows support issue. Testing through CI in github workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants