Inflection-94 Improve Wikidata coverage in dictionary-parser #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grhoten
commented
Mar 10, 2025
| # | ||
| # These are lexemes that should either be ignored due to irrelevance that can't be easily tagged as irrelevant, | ||
| # or words that are just not that common that should be sorted last in the inflection patterns. | ||
| L128740=omit |
There was a problem hiding this comment.
This noun is not typical, and it conflicts with the common pronoun. Remove it for now to deconflict it.
| # These are lexemes that should either be ignored due to irrelevance that can't be easily tagged as irrelevant, | ||
| # or words that are just not that common that should be sorted last in the inflection patterns. | ||
| L128740=omit | ||
| L166820=omit |
There was a problem hiding this comment.
This is стола, which is also the feminine form of стол (table). There is a conflict here. There are ways to deconflict this, but let's exclude this for now.
| @@ -2,9 +2,10 @@ | |||
| # | |||
| # These are lexemes that should either be ignored due to irrelevance that can't be easily tagged as irrelevant, | |||
| # or words that are just not that common that should be sorted last in the inflection patterns. | |||
| L15388=rare | |||
| L299075=omit | |||
| # TODO remove this, since it is fixed upstream. | |||
| L342586=omit | |||
There was a problem hiding this comment.
This can be removed after the next Wikidata dump is consumed.
| @@ -120,6 +120,7 @@ public String toString() { | |||
|
|
|||
| enum Tense { | |||
| PAST, | |||
| DISTANT_PAST, | |||
There was a problem hiding this comment.
Hindi concept for one word.
nciric
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94
There are some changes that can be made to reduce the number of test failures across languages being transitioned to use Wikidata.