Added the support for macos #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nciric
approved these changes
Mar 10, 2025
|
Approved and merged. Additional checks for Ubuntu don't slow down the CI so
they are ok.
Thanks for adding MacOS support, it works as expected!
пон, 10. мар 2025. у 11:25 Milan P Samuel ***@***.***> је
написао/ла:
… Hello @nciric <https://github.com/nciric> ,
I have added support for macOS. While installing ICU for macOS, I
encountered a warning that can sometimes be distracting:
***@***.*** 76.1_1 is already installed and up-to-date. To reinstall 76.1_1,
run: brew reinstall ***@***.***
To resolve this issue, I added a condition that first checks if ICU is
already installed. If it is, the installation step is skipped, and the
process moves to the next step.
brew list icu4c || brew install icu4c
Screenshot.2025-03-10.234608.png (view on web)
<https://github.com/user-attachments/assets/6eb63cb2-4672-4aee-87d2-6c1c28cd0c60>
Please review the macOS support I’ve added, and let me know if any changes
are needed.
------------------------------
You can view, comment on, or merge this pull request online at:
#96
Commit Summary
- 83ad438
<83ad438>
added the support for macos
File Changes
(1 file <https://github.com/unicode-org/inflection/pull/96/files>)
- *M* .github/workflows/cmake-multi-platform.yml
<https://github.com/unicode-org/inflection/pull/96/files#diff-e140c2f8e760152e341a3449a5d4c370af357beeb2ad3f163b7ed9e774769c54>
(17)
Patch Links:
- https://github.com/unicode-org/inflection/pull/96.patch
- https://github.com/unicode-org/inflection/pull/96.diff
—
Reply to this email directly, view it on GitHub
<#96>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7GEKWWJXWFFY5QOFYIVDL2TXKLHAVCNFSM6AAAAABYW4VC4CVHI2DSMVQWIX3LMV43ASLTON2WKOZSHEYDQMBYG44TANY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @nciric ,
I have added support for macOS. While installing ICU for macOS, I encountered a warning that can sometimes be distracting:
icu4c@76 76.1_1 is already installed and up-to-date. To reinstall 76.1_1, run: brew reinstall icu4c@76.
To resolve this issue, I added a condition that first checks if ICU is already installed. If it is, the installation step is skipped, and the process moves to the next step.
brew list icu4c || brew install icu4cPlease review the macOS support I’ve added, and let me know if any changes are needed.