Require prioritising syntax & data model errors #1011
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
reviewed
Feb 17, 2025
| @@ -44,7 +44,7 @@ or separately by more than one such method. | |||
| When a message contains more than one error, | |||
| or contains some error which leads to further errors, | |||
| an implementation which does not emit all of the errors | |||
| SHOULD prioritise _Syntax Errors_ and _Data Model Errors_ over others. | |||
| MUST prioritise _Syntax Errors_ and _Data Model Errors_ over others. | |||
There was a problem hiding this comment.
I don't think we should take this today. We can make it MUST in 48.
There was a problem hiding this comment.
I agree, for discussion for v48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should tighten up our requirement about error priority; there's no reason to keep this as a SHOULD instead of a MUST. The syntax & data model errors are also determinable before runtime.