Clarify option resolution regarding fallback option values #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
approved these changes
Mar 6, 2025
eemeli
requested changes
Mar 7, 2025
There was a problem hiding this comment.
The current indentation is intentional, and options resolving to fallback values are meant to be left out of res. This was most recently discussed in #903 (comment).
Rather than changing the algorithm, we should probably add a note about this.
Added a note explaining the fallback resolved values are not valid options and the option is thus omitted. I also reworded the emit-bad-option step to make it not look like an if statement missing an else
rv is a fallback value|
@eemeli I added the note you suggest. I also reworded the step in question to not make it look like an "if XXX" step in the algorithm (leading to the commenter's query about "where's the else"). See what you think. |
eemeli
approved these changes
Mar 9, 2025
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1053.