Fix unpaired surrogate in test #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1062 per 2025-04-21 call
Comments, of course, are not legal JSON either, but sometimes work... removing here so we can handle differently.
eemeli
requested changes
Apr 22, 2025
There was a problem hiding this comment.
If we don't want to include an escaped unpaired surrogate to accommodate a possible understanding of the JSON spec, we should not include a double-escaped one either.
In other words, if this one particular feature is not representable in JSON, we should instead describe the required test in test/README.md or somewhere else, as it'll need special handling in any case.
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
|
Fair point. I'll modify the readme in the next push. |
eemeli
requested changes
Apr 22, 2025
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
eemeli
approved these changes
Apr 22, 2025
catamorphism
approved these changes
Apr 22, 2025
mihnita
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062 per 2025-04-21 call