Skip to content

Define new error "Unknown Markup" #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Define new error "Unknown Markup" #357

wants to merge 3 commits into from

Conversation

aphillips
Copy link
Member

From a discussion about the ABNF with @eemeli I noticed that we don't have an error for when markup is not recognized. Proposing a fix.

@aphillips
Define new error "Unknown Markup"
39cc138 
From a discussion about the ABNF with @eemeli I noticed that we don't have an error for when `markup` is not recognized. Proposing a fix.
@mihnita
Copy link
Collaborator

mihnita commented Feb 21, 2023

I think that markup is still not agreed on.
So adding some error for it only adds stuff to cleanup after.

@mihnita
Copy link
Collaborator

mihnita commented Feb 21, 2023

Markup open issues:

And to show that it was not agreed on, see PR #283 in Jun 21, 2022:

I will approve it to move things forward and not have these many open PRs.
It does not mean I agree with this syntax, so it should not be hold against me 1 month from now ("but you approved X")
There are still at least 2 open issues arguing about how to best handle "markup elements"

eemeli
eemeli approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and well in line with the Unknown Function error.

Some nitpicks inline.

aphillips and others added 2 commits February 22, 2023 07:49
@aphillips @eemeli
Update spec/formatting.md
e6f93fe 
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
@aphillips @eemeli
Update spec/formatting.md
3466d33 
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
@aphillips aphillips added the Agenda+ Requested for upcoming teleconference label Feb 23, 2023
@eemeli eemeli mentioned this pull request Apr 10, 2023
Closed
@aphillips aphillips closed this May 22, 2023
@aphillips
Copy link
Member Author

close in telecon 2023-05-22

@aphillips aphillips deleted the aphillips-markup-error-proposed branch July 24, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

@stasm stasm Awaiting requested review from stasm

@echeran echeran Awaiting requested review from echeran

@mihnita mihnita Awaiting requested review from mihnita

Assignees
No one assigned
Labels
Agenda+ Requested for upcoming teleconference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aphillips @mihnita @eemeli