Explicitly define operand in syntax
#395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To bikeshed on the name a bit, one possible alternative to expression = "{" [s] ((value [s annotation]) / annotation) [s] "}"
value = literal / variable
annotation = (function *(s option)) / reserved
option = name [s] "=" [s] value |
|
Not a blocker, but the value of 'operand' is that it reduces confusion with 'value' used as a normal English word. |
|
In your very next PR, you have in the text "...determines the value of a part of the message..." |
stasm
approved these changes
Jun 18, 2023
aphillips
requested changes
Jun 19, 2023
eemeli
commented
Jun 19, 2023
Noticing that is what prompted me to consider value, actually, as "operand" doesn't really work conceptually as the value of an option. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the data model and formatting, I found it a bit challenging to not have the operand of an expression defined in the syntax, even though it needs to be referred to all over the place.
So let's add that, and move the function sigil description to the right section of the spec.