Skip to content

Bringing the spec description in sync with the abnf #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Bringing the spec description in sync with the abnf #447

wants to merge 0 commits into from

Conversation

mihnita
Copy link
Collaborator

@mihnita mihnita commented Jul 31, 2023

The .abnf is now this:

variable = "$" name
function = (":" / "+" / "-") name

In {b :html} the :html is the function, not b (similar to {43 :number} and {|20231217T1930| :datetime})

@mihnita mihnita requested review from eemeli, aphillips and stasm July 31, 2023 22:05
@aphillips
Copy link
Member

You're not wrong. Note the changes in #441 and the move towards defining standalone/opening/closing "elements", which should properly be termed expression.

@mihnita
Copy link
Collaborator Author

mihnita commented Aug 1, 2023

Note the changes in #441

If it helps with the refactoring you are trying to do I can either delay this until after you land #441, or you can make the change directly in #441.

@eemeli
Copy link
Collaborator

eemeli commented Aug 1, 2023

I think this is blocked by #441, and I'd really rather not introduce further increases to its scope from its current rather massive extent, but discuss changes like this after that PR has been merged.

@aphillips
Copy link
Member

Per teleconference, please refector to fit in the syntax.md file and then ping me to merge.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on prior meetings, this PR should be rebased on the latest main for further consideration.

@mihnita
Copy link
Collaborator Author

mihnita commented Sep 4, 2023

Replaced by #466
This one was too messy to merge. And was done in my main, making it worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants