Skip to content

Add proposed/accepted status to design docs #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2023
Merged

Add proposed/accepted status to design docs #461

merged 2 commits into from
Sep 2, 2023

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Aug 28, 2023

We should track and signal the status of a design document, so that we can iterate on them across multiple PRs. To keep it simple, we probably don't need more than two statuses to start with, "proposed" and "accepted".

CC @ryzokuken, who also has a design doc PR in flight.

@eemeli eemeli added design Design document or issues related to design meta labels Aug 28, 2023
@eemeli eemeli requested review from aphillips and stasm August 28, 2023 21:02
aphillips
aphillips requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But otherwise ready...

@eemeli eemeli mentioned this pull request Aug 29, 2023
Merged
@eemeli @aphillips
Update exploration/0000-design-proposal-template.md
30f74ee 
Co-authored-by: Addison Phillips <addisonI18N@gmail.com>
@eemeli
Copy link
Collaborator Author

eemeli commented Aug 29, 2023

Requesting fast-tracking.

@stasm
Copy link
Collaborator

stasm commented Aug 29, 2023

In my mind, a design doc would only be merged into main when it's accepted. Furthermore, I think that splitting a design doc into multiple PRs may again make it more difficult to track the discussion around it. Instead, I think we should encourage long-lived PRs and multiple rounds of reviews.

@eemeli
Copy link
Collaborator Author

eemeli commented Aug 30, 2023

@stasm Could you review #458, as that's effectively the prototypical reason for this change?

It's currently at 35 comments in 13 threads of review comments, most of which are hidden as resolved. If we don't make this change, we won't be able to merge the PR until all expression attribute design questions are answered, including e.g. whether it's the proper vessel for communicating "open" vs. "closed" concepts which have not yet been mentioned at all.

@eemeli eemeli mentioned this pull request Aug 31, 2023
Merged
@eemeli eemeli added the fast-track Editorial change permitted to use fast-track merge rules label Aug 31, 2023
@eemeli eemeli requested a review from aphillips September 2, 2023 10:25
@aphillips aphillips merged commit 76aaca8 into unicode-org:main Sep 2, 2023
@eemeli eemeli deleted the design-doc-status branch September 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphillips aphillips aphillips approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@stasm stasm Awaiting requested review from stasm

Assignees
No one assigned
Labels
design Design document or issues related to design fast-track Editorial change permitted to use fast-track merge rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eemeli @stasm @aphillips @ryzokuken