Skip to content

Remove the Prettier push action #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove the Prettier push action #491

merged 1 commit into from
Oct 10, 2023

Conversation

stasm
Copy link
Collaborator

@stasm stasm commented Oct 10, 2023

Following the (short) discussion in #481 (comment) and then after the 2023-10-09 teleconference, we agreed to remove the Prettier push action, originally introduced in #451.

@stasm stasm requested review from aphillips and eemeli October 10, 2023 10:07
@stasm
Copy link
Collaborator Author

stasm commented Oct 10, 2023

@eemeli Is there anything else to remove or de-configure?

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, that should do it.

@eemeli eemeli added the fast-track Editorial change permitted to use fast-track merge rules label Oct 10, 2023
@aphillips aphillips merged commit f1f0269 into main Oct 10, 2023
@eemeli eemeli deleted the remove-prettier-lint branch October 10, 2023 14:49
aphillips added a commit that referenced this pull request Oct 11, 2023
* Create notes-2023-10-02.md (#486)

* Design document for variable mutability and namespacing (#469)

* Design document for variable mutability and namespacing

* style: Apply Prettier

* Partly address #299

* style: Apply Prettier

* Address comments, fix sigil choice

- change `@` to `#` because we want to use `@` for annotations such as `@locale`
- Provide text that considers not making ugly local variables
- Provide use cases for static analysis
- Call out the perfidy of the author in stealing ill-baked requirements

* style: Apply Prettier

* Add @eemelie's `input` proposal as an option considered

* Update exploration/variable-mutability.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Add new proposed design

* Update exploration/variable-mutability.md

Co-authored-by: Addison Phillips <addison@unicode.org>

* Address @eemeli's comments

Specifically the one about forward references

* style: Apply Prettier

* Update exploration/variable-mutability.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update exploration/variable-mutability.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update exploration/variable-mutability.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Create notes-2023-10-09.md

* Update notes-2023-10-09.md

* Remove the Prettier push action (#491)

Remove the Prettier lint action

* Remove numbers from the existing design proposals (#490)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Editorial change permitted to use fast-track merge rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants