Flatten JSON & TS data model Pattern element #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
reviewed
Jan 10, 2024
Co-authored-by: Addison Phillips <addisonI18N@gmail.com>
aphillips
approved these changes
Jan 10, 2024
gibson042
approved these changes
Jan 10, 2024
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
eemeli
added a commit
that referenced
this pull request
Jan 12, 2024
Merged
aphillips
pushed a commit
that referenced
this pull request
Jan 13, 2024
eemeli
added a commit
to messageformat/messageformat
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from writing the JS implementation:
In the data model, the wrapping object in the
Patternwhich has a singlebodyproperty is rather useless. We should flatten this to simplify the model a bit.One reason why the wrapping object was included earlier was to enable an extension of the data model to function as a CST, but in practice I at least found that its requirements are sufficiently different for the CST to work better as a separately defined structure.
This PR overlaps a bit with #574; whichever lands second will need a small adjustment to deconflict the merge.