Port ABNF fix to relevant mention in syntax document #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
approved these changes
Jan 23, 2024
|
This is fine. The beautification was landed in the ABNF first. The copies in syntax.md are informative. |
gibson042
approved these changes
Jan 23, 2024
|
fast-track requirements met |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #614.
I also notice some of the beautification from #613 didn't land here so maybe you have other plans to update these code blocks to match, but I didn't bother trying to apply any of them as they should be only decorative and I didn't know if you wanted them in an unrelated PR. This change fixing an actual syntax problem needs updating even if the formatting changes aren't urgent to touchup.