Skip to content

Address #575: say that data model uses name for identifier #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2024
Merged

Address #575: say that data model uses name for identifier #668

merged 3 commits into from
Feb 20, 2024

Conversation

aphillips
Copy link
Member

Per our discussion of #575, we want to say that the field name in the data model encompasses the production identifier in cases where the name is an identifier.

Fixes #575.

@aphillips
Address #575: say that data model uses name for identifier
121804d 
Per our discussion of #575, we want to say that the field `name` in the data model encompasses the production `identifier` in cases where the name is an identifier.

Fixes #575.
@aphillips aphillips added data model Issues related to the Interchange Data Model fast-track Editorial change permitted to use fast-track merge rules editorial Issue is non-normative LDML45 LDML45 Release (Tech Preview) labels Feb 18, 2024
eemeli
eemeli approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See slight reordering inline.

@aphillips @eemeli
Apply suggestions from code review
b91f651 
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
@aphillips
Copy link
Member Author

@stasm Can I get a ship-it?

@aphillips aphillips merged commit 003be40 into main Feb 20, 2024
@aphillips aphillips deleted the aphillips-data-model-name-note branch February 20, 2024 14:08
@eemeli eemeli mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

@stasm stasm Awaiting requested review from stasm

@echeran echeran Awaiting requested review from echeran

@mihnita mihnita Awaiting requested review from mihnita

Assignees
No one assigned
Labels
data model Issues related to the Interchange Data Model editorial Issue is non-normative fast-track Editorial change permitted to use fast-track merge rules LDML45 LDML45 Release (Tech Preview)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The data model uses "name" for both namespaced and non-namespaced names
2 participants
@aphillips @eemeli