-
-
Notifications
You must be signed in to change notification settings - Fork 36
Fix whitespace conformance to match UAX31 (including permitting LRM/RLM) #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b387301
Allow LRM in whitespace
aphillips ae712d7
Update syntax.md
aphillips c556ecf
Make 3a-2 definition consistent with requirements
aphillips 8558eef
Update spec/syntax.md
aphillips d830550
Replace `[s]` with owsp production
aphillips 42b7744
`s` != `wsp`
aphillips af75420
Update syntax.md
aphillips 6a6dc70
Update message.abnf
aphillips db5e97c
Update spec/syntax.md
aphillips 3fede7a
Update spec/syntax.md
aphillips 586a4d6
Update spec/syntax.md
aphillips 502e1fe
Update spec/syntax.md
aphillips d7af5eb
Address literals
aphillips 68f32f8
Fix converting some `s` productions to `wsp`
aphillips e36d01d
Add bidi isolate support
aphillips 5609dc0
Missing one "x"
aphillips e74b34c
Add a warning/tech preview feedback note
aphillips 9557849
Update spec/syntax.md
aphillips ec369ec
Update spec/syntax.md
aphillips 2532206
Address @macchiati's comment
aphillips f985860
Update spec/syntax.md
aphillips 52c5c86
Update spec/syntax.md
aphillips 4a6c96c
Fix up @machiatti's suggested text
aphillips 19864c3
Address @mihnita's suggestion, fix expression brackets
aphillips 27b9e42
Make syntax.md make abnf
aphillips 00e3796
Merge branch 'main' into aphillips-allow-lrm
aphillips File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding words Just to make it clear what the list is telling people to not do (vs. whether they are supposed to do it). Also, I think you want a newline to ensure that the following sentences of the note don't get collapsed into the second bullet point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I am making changes to this text as I incorporate it into a new PR that replaces this one and implements the bidi design.