Skip to content

Get rid of many symbol tables #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 8, 2025
Merged

Get rid of many symbol tables #1085

merged 15 commits into from
Apr 8, 2025

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Apr 8, 2025 •
edited
Loading

Fix #1073, making progress towards #1074.

@eggrobin eggrobin marked this pull request as ready for review April 8, 2025 12:54
@eggrobin eggrobin requested a review from markusicu April 8, 2025 12:54
@eggrobin
Copy link
Member Author

eggrobin commented Apr 8, 2025

Note: The extraneous toSkeleton calls removed by 3883c3e currently cause \p{lb=/^$/} to be equal to \p{lb=IS}, even though LM3 is not supposed to be applied for regex queries.

markusicu
markusicu approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo! thanks!!

@eggrobin eggrobin merged commit 7628438 into unicode-org:main Apr 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There can only be one XSymbolTable
2 participants
@eggrobin @markusicu