-
-
Notifications
You must be signed in to change notification settings - Fork 44
Supply the field indices and correct the types of NormalizationCorrections data #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply the field indices and correct the types of NormalizationCorrections data #1087
Conversation
Will UCDXML be able to call the regular Unicode Tools functions after this, rather than parsing it independently? |
That is a question for @jowilco, but of course I would like to minimize the number of UCD parsers we spawn here… |
@markusicu , @eggrobin
|
Fair point. Effectively, it would mean removing one parser, but adding something equivalent to MakeUnicodeFiles (the UCD file generator), and that way madness also lies. |
Before this change, all three normalization_correction_* pseudoproperties have the value
96FB
(that is, a four-character string) for U+F951.This was not a problem for UCDXML as that one parses the file independently,
unicodetools/unicodetools/src/main/java/org/unicode/xml/UCDDataResolver.java
Lines 189 to 197 in 7628438
Also fix UnicodeProperty getSet on string-valued or miscellaneous properties of strings (although UnicodeProperty still leaves a lot to be desired for properties of strings; in particular, it has no way to get the value for a string!).