Skip to content

Do not fall back when looking for 4.1 data or later #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Do not fall back when looking for 4.1 data or later #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8c199
Do not fall back when looking for 4.1 data or later
eggrobin Apr 9, 2025
5207537
spots
eggrobin Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions unicodetools/src/main/java/org/unicode/text/utility/Utility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,6 +1451,14 @@ public static String getMostRecentUnicodeDataFile(
if (version != null && version.compareTo(currentVersion) < compValue) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Hopefully in the future we can completely stop looping over the versions in the searchPath...

continue;
}
if (version != null
&& version.compareTo(VersionInfo.UNICODE_4_1) >= 0
&& currentVersion.compareTo(version) < 0) {
// Do not look at earlier versions if we want Unicode 4.1 data or later.
// Unicode 4.0.1 is the last version for which unmodified files were not
// republished.
return null;
}
// check the standard ucd directory
if (filename.contains("/*/")) {
// check the idna directory
Expand Down
4 changes: 4 additions & 0 deletions unicodetools/src/main/resources/org/unicode/text/UCD/UnicodeInvariantTest.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,6 +1295,10 @@ Let $japaneseSimplifiedRadicals := \p{Name=/CJK RADICAL J-SIMPLIFIED/}
In $chineseSimplifiedRadicals, Equivalent_Unified_Ideograph ∈ [\p{kRSUnicode=/^[0-9]+'\.0$/} $radicalsWithUnifiableSimplifications]
In $japaneseSimplifiedRadicals, Equivalent_Unified_Ideograph ∈ \p{kRSUnicode=/^[0-9]+''\.0$/}

# Check that removed properties do not persist.
\p{U16:kGB7≠@none@}=[垯屃慭梾疭瘆筼臜荙诐跶轪辌酦镈镋镕饳馉鱽鱾鲃鲉鲌鲏鲪鲬鲯鲹鲾鳂鳈鳉鳑鳚鳡鳤鸻鸼鹟鹮鹲]
\p{kGB7≠@none@}=[]

# Tangut invariants

Let $tangutSourcesScope := [\p{Block=/^Tangut(.Supplement)?$/} - \p{gc=Cn}]
Expand Down
Loading