Skip to content

Ucdxml 17v1 #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
May 9, 2025
Merged

Ucdxml 17v1 #1104

merged 29 commits into from
May 9, 2025

Conversation

jowilco
Copy link
Contributor

@jowilco jowilco commented Apr 25, 2025 •
edited
Loading

  1. Addresses https://www.unicode.org/L2/L2019/19270.htm#160-A10 by consuming the RegEx syntax for Unihan directly from UAX38.
  2. Resolved https://www.unicode.org/L2/L2024/24221.htm#181-A43 by removing kGB7.
  3. Resolved https://www.unicode.org/L2/L2024/24221.htm#181-A131 by updating the RegEx for the na attribute.
  4. Addresses https://www.unicode.org/L2/L2024/24221.htm#181-A133 by adding support for Unicode Version 17.0
  5. Resolved https://www.unicode.org/L2/L2025/25085.htm#183-A100 by removing kJa.
  6. Resolved https://www.unicode.org/L2/L2025/25085.htm#183-A127 by adding kTayNumeric.
  7. Resolved https://www.unicode.org/L2/L2025/25085.htm#183-A180. All Unihan syntaxes are sourced directly from UAX38.
  8. Addresses UCDXML: add Unikemet properties #921 by adding support for Unikemet.
  9. Resolved Update UAX42 to document that common Unihan attributes are grouped starting with Unicode 17 #1071 by adding a comment indicating that "Unihan attributes are applied at the group where applicable, similar to how non-Unihan attributes are applied at the group."
  10. Partially addresses Update UAX42 to document which UCDXML fields correspond to UCD properties (UAX44) vs. which are “just data” corresponding to various UCD files #1049 by removing Deprecated properties, Normalization Corrections, and Emoji Sources.

@jowilco jowilco marked this pull request as draft April 25, 2025 00:17
@jowilco jowilco requested a review from markusicu April 25, 2025 00:17
@markusicu markusicu self-assigned this Apr 25, 2025
@markusicu
Copy link
Member

Hi @jowilco the CI failures suggest that you need to run GenerateEnums again, and also mvn spotless:apply.

@jowilco
Copy link
Contributor Author

jowilco commented Apr 25, 2025

Hi @jowilco the CI failures suggest that you need to run GenerateEnums again, and also mvn spotless:apply.

Agreed. This is still a draft pending the fixes for TR57. I'll definitely clean everything up before removing the draft status.

markusicu
markusicu reviewed Apr 25, 2025
View reviewed changes
@jowilco jowilco changed the base branch from main to trunk April 29, 2025 18:08
@jowilco jowilco changed the base branch from trunk to main April 29, 2025 18:08
@markusicu markusicu marked this pull request as ready for review May 8, 2025 18:39
@markusicu
Copy link
Member

@jowilco there are merge conflicts. Please update from main and fix as necessary.

I suspect that it's because both you and @eggrobin are adding extra properties.

@jowilco
Copy link
Contributor Author

jowilco commented May 9, 2025 •
edited
Loading

@jowilco there are merge conflicts. Please update from main and fix as necessary.

I suspect that it's because both you and @eggrobin are adding extra properties.

@markusicu -- I just merged upstream/main again to this branch, but I didn't get any merge conflicts. Not sure why you are seeing a conflict.

@eggrobin
Copy link
Member

eggrobin commented May 9, 2025

Not sure why you are seeing a conflict.

I think this is because Markus has his merge button set to Rebase and merge (which is often a conflict party). You probably don’t want to rebase merge anyway, and squash and merge has no conflicts, so all is well.

@markusicu markusicu merged commit 97760fb into unicode-org:main May 9, 2025
16 checks passed
@markusicu
Copy link
Member

sorry for the noise about conflicts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@eggrobin eggrobin Awaiting requested review from eggrobin

@nedley nedley Awaiting requested review from nedley

@josh-hadley josh-hadley Awaiting requested review from josh-hadley

@Ken-Whistler Ken-Whistler Awaiting requested review from Ken-Whistler

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update UAX42 to document that common Unihan attributes are grouped starting with Unicode 17
3 participants
@jowilco @markusicu @eggrobin