Skip to content

Post-UTC-183 kenfiles #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 27, 2025
Merged

Post-UTC-183 kenfiles #1109

merged 11 commits into from
Apr 27, 2025

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Apr 25, 2025

From @Ken-Whistler:

UnicodeData-17.0.0d3.txt

Removed the three Sidetic characters whose approval we rescinded yesterday.

NameAliases-17.0.0d2.txt

Adds the 4 Bamum formal name aliases.

NamesList-17.0.0d15.txt

Regenerated. Picks up some annotations. Removes the 3 Sidetic
characters. Adds the 4 Bamum formal name aliases. And because this was
regenerated against Michel's latest Unikemet.txt, there are many updates
to the function notes in the Egyptian blocks.

UnicodeData-17.0.0d4.txt

Addition of 20C1 SAUDI RIYAL SIGN. Adjustment of two CJK extension ranges.

NamesList-17.0.0d16.txt

Regeneration to pick up 20C1 and the CJK extension ranges.

More updates:

EastAsianWidth-17.0.0d4txt

LineBreak-17.0.0d4.txt

VerticalOrientation-17.0.0d5.txt

I expect those will be auto-generated out of the tools, but since EAW
involved an explicit decision to change some values, I generated them,
too, for cross-checking.


@eggrobin replied:

UnicodeData-17.0.0d4.txt

Addition of 20C1 SAUDI RIYAL SIGN. Adjustment of two CJK extension ranges.

That one differs from mine: you are missing the changes from decision 181-C52.

EastAsianWidth-17.0.0d4txt

Looks good.

LineBreak-17.0.0d4.txt

Missing 181-C53 and 181-C54.

VerticalOrientation-17.0.0d5.txt

Looks good.


@Ken-Whistler fixed those in UnicodeData-17.0.0d5.txt and LineBreak-17.0.0d5.txt.

The changes to NamesList.txt are made on top of the previous change to NamesList.txt, 2160216.
Since they are out-of-order, the changes to other files are instead made on top of 14496bf (the last change to UnicodeData from KenW), and are merged in at the end.

@eggrobin
Copy link
Member Author

(Judging from what is missing here, I guess I the UnicodeData.txt and LineBreak.txt commits would be more readable if I had made them on top of 14496bf rather than 2160216. I might try that.)

eggrobin and others added 3 commits April 26, 2025 01:10
Regenerated. Picks up some annotations. Removes the 3 Sidetic
characters. Adds the 4 Bamum formal name aliases. And because this was
regenerated against Michel's latest Unikemet.txt, there are many updates
to the function notes in the Egyptian blocks.

Co-authored-by: Ken-Whistler <ken@unicode.org>
Regeneration to pick up 20C1 and the CJK extension ranges.

Co-authored-by: Ken-Whistler <ken@unicode.org>
Removed the three Sidetic characters whose approval we rescinded yesterday.

Co-authored-by: Ken-Whistler <ken@unicode.org>
eggrobin and others added 7 commits April 26, 2025 01:26
Adds the 4 Bamum formal name aliases.

Co-authored-by: Ken-Whistler <ken@unicode.org>
Addition of 20C1 SAUDI RIYAL SIGN. Adjustment of two CJK extension ranges.

Co-authored-by: Ken-Whistler <ken@unicode.org>
…on-17.0.0d5.txt.

I expect those will be auto-generated out of the tools, but since EAW
involved an explicit decision to change some values, I generated them,
too, for cross-checking.

Co-authored-by: Ken-Whistler <ken@unicode.org>
Applied UTC-181-C52.

Co-authored-by: Ken-Whistler <ken@unicode.org>
Applied UTC-181-C53 and UTC-181-C54.

Co-authored-by: Ken-Whistler <ken@unicode.org>
@eggrobin eggrobin marked this pull request as ready for review April 25, 2025 23:33
@eggrobin eggrobin requested a review from markusicu April 25, 2025 23:33
@eggrobin
Copy link
Member Author

eggrobin commented Apr 25, 2025

@markusicu: I think I want to merge, rather than squash-and-merge, this one, since it reflects the history of an independently maintained copy of the files where the same changes were made out of order.

I can add a commit to revert the timestamp-only changes if you want.

@markusicu
Copy link
Member

@markusicu: I think I want to merge, rather than squash-and-merge, this one, since it reflex a the history of an independently maintained copy of the files where the same changes were made out of order.

I really don't like non-linear history on main, and I think that the PR description suffices.

I can add a commit to revert the timestamp-only changes if you want.

Please do.

@eggrobin
Copy link
Member Author

I can add a commit to revert the timestamp-only changes if you want.

Please do.

Done. I did not revert the timestamp change to NameAliases, since the new timestamp is clearly better than the old one (from last year!).

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx -- please squash-and-merge

@eggrobin eggrobin merged commit fa376ca into unicode-org:main Apr 27, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants