Skip to content

Add more tools to CI and docs #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 21, 2022
Merged

Add more tools to CI and docs #205

merged 14 commits into from
Apr 21, 2022

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Mar 7, 2022 •
edited
Loading

Contributes to #187

@markusicu
Copy link
Member

@echeran Good time to make progress?
Maybe check in one PR for some tools and then create one or more additional ones?

@echeran echeran marked this pull request as ready for review April 19, 2022 21:32
@echeran echeran requested review from markusicu and srl295 April 19, 2022 21:32
@echeran
Copy link
Contributor Author

echeran commented Apr 19, 2022

@markusicu Good idea, I changed this PR from "draft" to "ready for review".

markusicu
markusicu reviewed Apr 20, 2022
View reviewed changes
markusicu
markusicu previously approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

please apply one more typo fix and then squash-and-merge

@echeran @markusicu
Update .github/workflows/cli-build-instructions.yml
6cd36bf 
Co-authored-by: Markus Scherer <markus.icu@gmail.com>
markusicu
markusicu approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@echeran echeran merged commit 7528362 into unicode-org:main Apr 21, 2022
@markusicu
Copy link
Member

Thanks! I checked off two of the items in issue #187, please double-check.
I left UCA.Main unchecked since running it with one of its important arguments is commented out (and apparently needs some debugging).

@echeran echeran linked an issue May 24, 2022 that may be closed by this pull request
auto-run documented tool programs #187
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@srl295 srl295 Awaiting requested review from srl295

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-run documented tool programs
2 participants
@echeran @markusicu