add Eclipse .settings/ to .gitignore #217
Conversation
|
Could you move this .gitignore just under |
Should I check in the new .settings/ instead of ignoring it? Elango made the point that VS Code etc. settings are ignored, so he thinks we should treat Eclipse the same. |
There are already .settings files checked in elsewhere. Some of them has formatting settings. I would propose either:
or
|
|
FYI: PR #225 just added three files into |
|
I find it very annoying that it seems like every other time I want to make
a pull request in CLDR, etc., there are some new eclipse .files that are
created. I don't know what changed and shouldn't have to.
So either we should
1. always check them in, OR
2. never check them in (eg mark as ignored, except for specific
instances like where we all agree on new settings).
…On Tue, Apr 12, 2022 at 10:12 AM Steven R. Loomis ***@***.***> wrote:
Could you move this .gitignore just under unicodetools-testutils? We
already have .settings files checked in elsewhere.
Should I check in the new .settings/ instead of ignoring it?
Elango made the point that VS Code etc. settings are ignored, so he thinks
we should treat Eclipse the same. I am not sure what the ramifications
are...
There are already .settings files checked in elsewhere. Some of them has
formatting settings. I would propose either:
1. just ignore unicodetools-testutils/.settings
or
1. if we add the .settings gitignore to the top level, also remove the
.settings files.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMDVEJMT4URLJV2NHJDVEWVG5ANCNFSM5SWSJBFA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
The problem is it's not always clear when something is a new setting (such as java 8 vs 11) and when it is just noise. @nedley and others ran into issues where Eclipse isn't always able to create files from scratch, and gets stuck. As I noted in https://unicode-org.atlassian.net/browse/CLDR-15048?focusedCommentId=162936 what I have been doing myself is to use the |
|
It sounds like we've hit a point where we're working okay with Maven, and even fixes to Eclipse builds are really Maven fixes (ex: #225). Eclipse's integration with Maven is good enough that we're not benefiting from keeping the Eclipse dot files around. I think we should go with Option 2 and stop dealing with Eclipse settings dot files. The first thing would be to go ahead with this PR to add If that's ok, then we can follow up later with removing those files from the repo, to be done in conjunction with running Steven's command locally before we update from usptream: => |
|
- skip worktree takes individual file paths, not dirs.
- but yes I’m fine with this approach. If we are ok to forgo code style
settings etc. Maybe editorrc instead.
El El lun, abr. 25, 2022 a la(s) 4:35 p.m., Elango ***@***.***>
escribió:
… It sounds like we've hit a point where we're working okay with Maven, and
even fixes to Eclipse builds are really Maven fixes (ex: #225
<#225>). Eclipse's
integration with Maven is good enough that we're not benefiting from
keeping the Eclipse dot files around.
I think we should go with Option 2 and stop dealing with Eclipse settings
dot files. The first thing would be to go ahead with this PR to add
.settings/ to .gitignore.
If that's ok, then we can follow up later with removing those files from
the repo, to be done in conjunction with running Steven's command locally
before we update from usptream:
$ find . -name ".settings"
./unicodetools/.settings
./UnicodeJsps/.settings
./unicodetools-testutils/.settings
./.settings
=>
git update-index --skip-worktree ./unicodetools/.settings ./UnicodeJsps/.settings ./unicodetools-testutils/.settings ./.settings
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM5UB5R6RCBGK67UZW3VG4F2FANCNFSM5SWSJBFA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
In ICU, we have common, light-touch settings for things like order of imports, cleanup of generic-type decls, and removing trailing spaces. Is there a reasonable way to achieve these kinds of things across IDEs? Or would such things be a reasonable reason for keeping the .settings? |
|
https://editorconfig.org <https://editorconfig.org/>
a .editorconfig can do the tabs/spaces/indent stuff. However, doesn’t have great eclipse support it seems.
… On Apr 25, 2022, at 7:55 PM, Markus Scherer ***@***.***> wrote:
In ICU, we have common, light-touch settings for things like order of imports, cleanup of generic-type decls, and removing trailing spaces. Is there a reasonable way to achieve these kinds of things across IDEs? Or would such things be a reasonable reason for keeping the .settings?
—
Reply to this email directly, view it on GitHub <#217 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGQZM7AYASVORVERZTJ22LVG45JNANCNFSM5SWSJBFA>.
You are receiving this because your review was requested.
|
|
FYI as a data point. The ICU repo has lots of Eclipse .prefs files for a long time... |
|
FYI, I'm tired of getting messages like the following when I pull
From github.com:unicode-org/unicodetools
* branch main -> FETCH_HEAD
error: Your local changes to the following files would be overwritten by
merge:
UnicodeJsps/.settings/org.eclipse.core.resources.prefs
UnicodeJsps/.settings/org.eclipse.jdt.core.prefs
UnicodeJsps/.settings/org.eclipse.wst.common.component
UnicodeJsps/.settings/org.eclipse.wst.common.project.facet.core.xml
unicodetools/.project
unicodetools/.settings/org.eclipse.jdt.core.prefs
Please commit your changes or stash them before you merge.
error: The following untracked working tree files would be overwritten by
merge:
unicodetools/.settings/org.eclipse.wst.common.component
unicodetools/.settings/org.eclipse.wst.common.project.facet.core.xml
unicodetools/.settings/org.eclipse.wst.validation.prefs
Please move or remove them before you merge.
Aborting
…On Mon, Apr 25, 2022 at 5:55 PM Markus Scherer ***@***.***> wrote:
In ICU, we have common, light-touch settings for things like order of
imports, cleanup of generic-type decls, and removing trailing spaces. Is
there a reasonable way to achieve these kinds of things across IDEs? Or
would such things be a reasonable reason for keeping the .settings?
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMCRO72EDWMDEIH6U2LVG45JPANCNFSM5SWSJBFA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
These are the files upon which i use the |
|
Obsolete after PR #254. |
After importing the new Maven project into Eclipse, git status reported that there was a new folder
unicodetools-testutils/.settings/. AFAIU we don't want to check in IDE-specific settings.