switch from ICU ObjectMatcher to Java Predicate #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
approved these changes
Apr 12, 2022
echeran
approved these changes
Apr 12, 2022
| * @return | ||
| */ | ||
| static <T, U extends Collection<T>> U retainAll(U c, Predicate<T> f) { | ||
| for (Iterator<T> it = c.iterator(); it.hasNext();) { |
There was a problem hiding this comment.
fyi: the Java 8 way of filtering a collection might look like:
return c.stream().filter(f).collect(Collectors.toList());
Just an FYI, since this is probably focused on the higher-level goal of refactoring code across projects.
There was a problem hiding this comment.
Thanks. My goal was to reduce the yellow warning markers in Eclipse, not to generally modernize the code. There is a ton of code in this project using very old-fashioned Java mechanisms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and then clean up most warnings in UnicodeProperty
For issue #66: This makes unicodetools UnicodeProperty more like CLDR UnicodeProperty. The CLDR version switched to Java Predicate in unicode-org/cldr#460. The warnings cleanup here goes farther than the earlier one in CLDR.
Best to review one commit at a time.