Skip to content

Add more tools to CI #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 11, 2022
Merged

Add more tools to CI #235

merged 11 commits into from
May 11, 2022

Conversation

echeran
Copy link
Contributor

@echeran echeran commented May 3, 2022

Part 2 of contributing to #187

@echeran echeran force-pushed the add-tools-to-docs-pt2 branch 3 times, most recently from e99084c to fff85c8 Compare May 7, 2022 00:47
@echeran echeran force-pushed the add-tools-to-docs-pt2 branch from fff85c8 to 7a6d587 Compare May 7, 2022 01:13
echeran
echeran commented May 7, 2022
View reviewed changes
Copy link
Contributor Author

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusicu I also added GenerateConfusables and committed the diffs caused by the output files -- do those changes make sense?

macchiati
macchiati previously approved these changes May 7, 2022
View reviewed changes
@markusicu
Copy link
Member

@markusicu I also added GenerateConfusables and committed the diffs caused by the output files -- do those changes make sense?

I suspect that the "security" output files are ok, but they should be updated in a separate PR, not together with this one. In a separate PR we can then discuss whether the output changes are all good.
(FYI https://github.com/unicode-org/unicodetools/blob/main/docs/security.md#generating)

@echeran echeran force-pushed the add-tools-to-docs-pt2 branch from 23d92f2 to 7a6d587 Compare May 10, 2022 01:06
@echeran echeran marked this pull request as ready for review May 10, 2022 01:19
@echeran
Copy link
Contributor Author

echeran commented May 10, 2022

I suspect that the "security" output files are ok, but they should be updated in a separate PR, not together with this one. In a separate PR we can then discuss whether the output changes are all good. (FYI https://github.com/unicode-org/unicodetools/blob/main/docs/security.md#generating)

Okay, I split off the part of this PR with the CI job for testing GenerateConfusables & the output files to #243 .

@echeran echeran requested a review from markusicu May 10, 2022 21:10
markusicu
markusicu reviewed May 11, 2022
View reviewed changes
markusicu
markusicu approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

@echeran echeran merged commit 72ddb17 into unicode-org:main May 11, 2022
@echeran echeran linked an issue May 24, 2022 that may be closed by this pull request
auto-run documented tool programs #187
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@macchiati macchiati macchiati left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-run documented tool programs
3 participants
@echeran @markusicu @macchiati