-
-
Notifications
You must be signed in to change notification settings - Fork 44
Prefer IndexUnicodeProperties over ToolUnicodePropertySource #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah, the code that generates DerivedNormalizationProps was relying on those nulls. I will have to fix that. |
That’s odd: on my machine it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
See discussion in #432 (comment):
@eggrobin:
@macchiati:
This uses IndexUnicodeProperties except for the following, where ToolUnicodePropertySource is used:
This is used for the invariant about NFKC_SCF, which does not exist until 15.1, but whose derivation would be stable very far back.
This also fixes defaults (incorrectly null instead of
<code point>
) in the NFKC_CF and NFKC_SCF returned by ToolUnicodePropertySource.