Update jsps for 15.1 beta #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmatically determine jspVersion instead of hard-code
srl295
previously approved these changes
Jun 1, 2023
macchiati
previously approved these changes
Jun 1, 2023
|
@markusicu did you want to have a look at this before I merge and hand off the deployment to you (or @srl295 or whoever wants to do it)? |
srl295
approved these changes
Jun 12, 2023
markusicu
reviewed
Jun 13, 2023
| @@ -43,7 +44,9 @@ public class CachedProps { | |||
| final BiMultimap<String, String> nameToAliases = new BiMultimap<String, String>(null, null); | |||
| final Map<String, BiMultimap<String, String>> nameToValueToAliases = new LinkedHashMap(); | |||
|
|
|||
| static CachedProps CACHED_PROPS = getInstance(VersionInfo.getInstance(14)); | |||
| static String jspVersion = IS_BETA ? Settings.lastVersion : Settings.latestVersion; | |||
| static VersionInfo jspVersionInfo = VersionInfo.getInstance(jspVersion); | |||
There was a problem hiding this comment.
Discussion: As long as we are serving ICU data, we should use jspVersionInfo = UCharacter.getUnicodeVersion();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated jsps for 15.1 beta.
Reviewers please note some related updates to CachedProps.java (set
IS_BETA = trueand also added some code to get the version without hard-coding).