Fix remaining issues with multivalued #618
Conversation
| } catch (Exception e) { | ||
| if (prop.isType(UnicodeProperty.BINARY_OR_ENUMERATED_OR_CATALOG_MASK)) { | ||
| try { | ||
| status = applyPropertyAlias0(prop, "No", result, !invert); |
There was a problem hiding this comment.
I understand that binary properties default to "No", but each enumerated/catalog property has its own @missing value, so why should those default to "No" rather than their actual @missing value?
There was a problem hiding this comment.
I'm just restricting the "No" default from applying to string/misc values, not introducing anything new for the others. Before changing that, we should have a discussion, probably in the CLDR/ICU design group to pull in everyone.
I think we explicitly wanted the "No" value to work in some enumerated properties, the ones with Yes, No, Maybe, for consistency.
Note that @missing isn't necessarily the best fallback value; it is just an feature of the file structure that allows us to minimize the number of lines we list. We would need to make that part of the discussion.
There were two further problems with multivalued support
The solution to these was to (1) allow for "" properly as a string value, and (2) allow script values that were not present in ScriptExtensions.txt as single values.
UnicodeJsps/src/main/java/org/unicode/jsp/ScriptTester.java
UnicodeJsps/src/main/java/org/unicode/jsp/UnicodeSetUtilities.java
UnicodeJsps/src/main/java/org/unicode/jsp/XPropertyFactory.java
UnicodeJsps/src/test/java/org/unicode/jsptest/TestMultivalued.java
unicodetools/src/main/java/org/unicode/props/UnicodeProperty.java
Notes: