Skip to content

Use cargo exclude for tests #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

djudd
Copy link

@djudd djudd commented Jan 5, 2019

Fixes #28

@djudd djudd changed the title Add cfg(test) to NORMALIZATION_TESTS [WIP] Add cfg(test) to NORMALIZATION_TESTS Jan 5, 2019
@djudd djudd changed the title [WIP] Add cfg(test) to NORMALIZATION_TESTS Add cfg(test) to NORMALIZATION_TESTS Jan 5, 2019
@Manishearth
Copy link
Member

lib.rs also needs a cfg(test) on the module declaration

@djudd
Copy link
Author

djudd commented Jan 10, 2019

Looks like that already exists in lib.rs actually: https://github.com/unicode-rs/unicode-normalization/blob/master/src/lib.rs#L70

Maybe that makes setting it on the constant redundant and the Cargo.toml change is the only one here that does anything?

@sujayakar
Copy link
Contributor

Yep, I think the issue in #28 is that the test files are included in the crate, not that they're getting compiled. The extant cfg(test) in lib.rs ensures they're not compiled. Revert to just the Cargo.toml change?

@djudd djudd force-pushed the no-package-test-code branch from f9c307b to 6bad95a Compare January 15, 2019 04:28
@djudd djudd changed the title Add cfg(test) to NORMALIZATION_TESTS Use cargo exclude for tests Jan 15, 2019
@djudd
Copy link
Author

djudd commented Jan 15, 2019

Rebased to drop the cfg commit

@sujayakar sujayakar merged commit 921cab3 into unicode-rs:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants