Add mixed-script detection #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems diverted a little from the original specification since there's no handling of the Zyyy and Zinh. (Maybe that's intentional, then maybe document it a little?) And maybe you want to bikeshed a little on the module name Otherwise looks good to me. |
|
@crlf0710 Zyyy and Zinh are already handled by the unicode-script crate. I'll leave a comment Heh, I realized I should rename it and did so before seeing your comment. I've also moved the identifier status stuff into its own similarly-named module. I don't have strong opinions about the name. |
|
Actually, no, I hadn't gotten the Zyyy/Zinh stuff exactly right. I'll fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, I'm using a git dependency right now, because the crate name is taken, but I have push access to the old crate and would rather just update it (see servo/unicode-script#6)
For prototyping this should be fine.
We should also move identifier profile stuff into a different module as well.
r? @crlf0710