You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you make just a small change to the Graphemes::next method then this breaks the tests in graphemes_test because the GraphemeCursor::next_boundary returns GraphemeIncomplete::PreContext(1). As far as I understand, this indicates that the cursor tries to look back at preceding grapheme clusters that it has already processed. I don't know if this behavior is intentional or required to process UTF-8 correctly, but it seems unnecessary because the tests do pass if you just use a fresh cursor instead and treat your current position as the start of the string. Some performance improvements might be possible if you do it that way.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
If you make just a small change to the
Graphemes::next
method then this breaks the tests ingraphemes_test
because theGraphemeCursor::next_boundary
returnsGraphemeIncomplete::PreContext(1)
. As far as I understand, this indicates that the cursor tries to look back at preceding grapheme clusters that it has already processed. I don't know if this behavior is intentional or required to process UTF-8 correctly, but it seems unnecessary because the tests do pass if you just use a fresh cursor instead and treat your current position as the start of the string. Some performance improvements might be possible if you do it that way.The text was updated successfully, but these errors were encountered: