Switch back to a non-defered service provider #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unfortunately, I realized that having the service provider be defered made the validation rules not load in time in some instances
|
In what instances @jkudish ? |
|
Running dusk tests, in my case |
|
Hmmmn, so how many times have you run with dusk tests? I just want to be sure that it actually doesn't load in time @jkudish ? |
|
Consistent failure when running on that environment. I also got the error with a manual test just now, so I'm pretty confident this is an actual problem. If I change it back to undeterred and run |
|
Alright, will merge it in! |
|
@jkudish I just tagged a new release. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, me again 👋
Unfortunately, I realized that having the service provider be deferred made the validation rules not load in time in some instances. This reverts that change.
Sorry for the trouble, unfortunately you'll have to cut another release 😦