Updated src/Paystack.php #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. UPDATE: The makePaymentRequest function builds the payload from the request, assuming the request as the only source of the payload. In a situation when Laravel is used strictly as an API backend, there are situations where the payload needs to be built dynamically, say from within the controller and not from a view or request. 2. NEW: Added getAuthorizationResponse function for a Laravel API scenario, where the controller may want take a different course of action if the initialization succeeded or not
| array_filter($data); | ||
| public function makePaymentRequest( $data = null) | ||
| { | ||
| if ( $data == null ) { |
There was a problem hiding this comment.
Please make use of the is_null method here like:
if (is_null($data)){...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: The makePaymentRequest function builds the payload from the request, assuming the request as the only source of the payload. In a situation when Laravel is used strictly as an API backend, there are situations where the payload needs to be built dynamically, say from within the controller and not from a view or request.
NEW: Added getAuthorizationResponse function for a Laravel API scenario, where the controller may want take a different course of action if the initialization succeeded or not