Added methods to handle Split payments #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Paystack.php
Outdated
| @@ -387,6 +391,7 @@ public function createCustomer() | |||
| ]; | |||
|
|
|||
| $this->setRequestOptions(); | |||
| $this->setHttpResponse('/customer', 'POST', $data); | |||
There was a problem hiding this comment.
Why is this code added here?
src/Paystack.php
Outdated
| ]; | ||
|
|
||
| $this->setRequestOptions(); | ||
| array_filter($data); |
There was a problem hiding this comment.
Please remove array_filter from here and just call it line 613 like so:
return $this->setHttpResponse('/subaccount', 'POST', array_filter($data))->getResponse();
src/Paystack.php
Outdated
| */ | ||
| public function listSubAccounts($per_page,$page){ | ||
|
|
||
|
|
There was a problem hiding this comment.
Any reason why we have some much whitespace here?
src/Paystack.php
Outdated
| ]; | ||
|
|
||
| $this->setRequestOptions(); | ||
| array_filter($data); |
There was a problem hiding this comment.
Please apply same logic here as mentioned above. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some useful methods for people looking to use the split payments feature that Paystack now provides