Skip to content

Removed line that fetches secret key in transaction form #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

Removed line that fetches secret key in transaction form #51

merged 1 commit into from
May 23, 2020

Conversation

derskeal
Copy link
Contributor

The payment still works without the line.

@derskeal
Removed line that fetches secret key
e06ab69 
The payment still works without the line.
@s-okubanjo
Copy link

Was about submitting an issue before I saw this.
Exposing your secret key in the form is a security flaw, as anybody that inspects your page's html can potentially use the Paystack api as you. The secret key can be fetched from the config or env file instead.
Cc @unicodeveloper
And update the Readme too.
Nice work!

@unicodeveloper unicodeveloper merged commit eef78e3 into unicodeveloper:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derskeal @s-okubanjo @unicodeveloper