Skip to content

TestReporterStdout::ReportSummary discrepancy between declaration and definition #15

Closed
@pjohnmeyer

Description

@pjohnmeyer

From http://code.google.com/p/unittestpp/issues/detail?id=8

A proprietary compiler that we're using is generating a warning on
TestReporterStdout::ReportSummary, because the header declaration does not exactly match the
source definition.

TestReporterStdout.h:

virtual void ReportSummary(
  int totalTestCount, int failedTestCount, int failureCount, float secondsElapsed);

TestReporterStdout.cpp:

void TestReporterStdout::ReportSummary(
  int const totalTestCount, int const failedTestCount, int const failureCount, float secondsElapsed)

Notice the extra "const"s in the definition. Even though they're arguably compatible, it's a bit of a
gray area. Even MSVC will complain in some cases when function signatures differ by a const
qualifier.

The simple fix is just to remove the consts in this cpp file.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions