Skip to content

Use size_t for array or vector index #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

killoctal
Copy link
Contributor

No description provided.

@pjohnmeyer
Copy link
Member

I need to do some local testing but this looks good so far. @charlesnicholson do you remember any reason why these were int instead of size_t? Unfortunately I don't believe I have any way of seeing the old svn logs.

@charlesnicholson
Copy link

I think when we wrote it we didn't know what size_t was. :(

This looks good, I think it should go in!

@killoctal
Copy link
Contributor Author

I did this for fix warnings when I use CHECK_ARRAY_* on a vector.
Maybe I missed some but I think there is the minimum requested :)

@pjohnmeyer pjohnmeyer added this to the 2.0.0 milestone Aug 31, 2016
@pjohnmeyer
Copy link
Member

There are many other places where an int today could be something unsigned like size_t, but it looks to me that you caught everything on the interface that had to do with array / vector sizes. Merging. Thanks!

@pjohnmeyer pjohnmeyer merged commit c431be9 into unittest-cpp:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants