Skip to content

Build pkgconfig file with CMake, not just with autoconf. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2017
Merged

Build pkgconfig file with CMake, not just with autoconf. #139

merged 1 commit into from
Jan 13, 2017

Conversation

edanaher
Copy link
Contributor

@edanaher edanaher commented Dec 1, 2016

I'm not an expert in CMake or pkg-config, but this seems to work.

It's also not particularly elegant, but is compatible with the existing autoconf-based pkg-config file generation.

@edanaher edanaher force-pushed the pkgconfig-with-cmake branch from 33d2312 to 40f90dc Compare December 1, 2016 17:52
@pjohnmeyer
Copy link
Member

My gut tells me all of these set calls aren't necessary, but I'm going to merge it since it seems to be doing what is intended. Thanks!

@pjohnmeyer pjohnmeyer merged commit 5e3b378 into unittest-cpp:master Jan 13, 2017
@pjohnmeyer pjohnmeyer added this to the 2.0.0 milestone Jan 13, 2017
@pjohnmeyer pjohnmeyer mentioned this pull request Jan 20, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edanaher @pjohnmeyer