Converted integral stream testing to min/max/mid style. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded strings for each sizeof() the common integral sizes to eliminate dependency on platform-specific sizes.
pjohnmeyer
added a commit
that referenced
this pull request
Feb 9, 2013
…MemoryOutStream Converted integral stream testing to min/max/mid style. Fixes #14.
pjohnmeyer
added a commit
that referenced
this pull request
Apr 4, 2015
…MemoryOutStream Converted integral stream testing to min/max/mid style. Fixes #14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #14 more thoroughly. While I believe the core issue had already been fixed, there seemed to be a lack of testing around integral streaming so I employed min/mid/max and hard-coded correct strings. I probably could have done something more clever that didn't require the repeated sizeof calls, but ultimately decided on simple code with no additional template or macro magic.