-
Notifications
You must be signed in to change notification settings - Fork 133
refactor: add query
alias to params
option
#105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for PR @huynl-96. I think we can introduce query and deprecate params without breaking changes and it is good to go. |
@pi0 I've added a deprecated warning for |
2e099ea
to
bed07d2
Compare
params
to query
params
to query
with backward compatibility
params
to query
with backward compatibilityquery
alias to params
option
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 85.43% 85.47% +0.04%
==========================================
Files 5 5
Lines 302 303 +1
Branches 60 60
==========================================
+ Hits 258 259 +1
Misses 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @huynl-96. Sorry it took long for me back to this. I had been thinking it might be better to support both options as alias (without deprecation) because the same "query string" is also named "URL search params" in other standards. Also using "Query search params" in docs to make it readable in both ways. |
Don't worry about it, hope you are feeling better now.
Looks good to me, no concern about it |
Resolves #73