-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(azure-key-vault-driver): fix character encoding #308
Conversation
β Live Preview ready!
|
"/": "s", | ||
"=": "-e-", | ||
"+": "-p-", | ||
"/": "-s-", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it makes sense / be possible that we use url encoding? (=
~> %3D
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not, as Key Vault only supports dashes besides alphanumeric characters. This replacement is only necessary because of the potential characters that could result in a base64 encoding. B64 was the only encoding I found that is available without adding an additional dependency and without requiring a custom implementation of an encoding scheme. As dashes are the only allowed characters and there were too many edge cases with replacing the special characters of b64 with alphanumeric characters or only one dash, this was the least overhead solution.
I can add an additional test of course to validate the encoding.
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 29 29
Lines 3417 3418 +1
Branches 521 521
=======================================
+ Hits 2664 2665 +1
Misses 752 752
Partials 1 1
|
Thanks! |
β Type of change
π Description