Skip to content

feat(cli): add back tsConfigPath option to component.json #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

feat(cli): add back tsConfigPath option to component.json #1330

wants to merge 10 commits into from
+3,052 −865

Conversation

sadeghbarati
Copy link
Collaborator

@sadeghbarati sadeghbarati commented Jul 4, 2025 •
edited
Loading

🔗 Linked issue

Close #1243

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Add tsConfigPath options to the components.json options schema
  • Add main shadcn-ui CLI changes
  • Use c12 again for loading component.json/json5/js/ts (it is working in Nuxt projects with empty or full components directory)
  • Enable shims and add nodeProtocol: strip to remove node: protocol from the build

📸 Screenshots (if appropriate)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati
feat(cli): add back tsconfigPath option to component.json
3147922 
add main shadcn-ui cli changes
use c12 again for loading component.json/json5/js/ts
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 4, 2025 •
edited
Loading 

npm i https://pkg.pr.new/shadcn-vue@1330

commit: 35dcdad

@sadeghbarati sadeghbarati added the help wanted Extra attention is needed label Jul 4, 2025
@sadeghbarati sadeghbarati requested a review from zernonia July 5, 2025 16:31
@sadeghbarati sadeghbarati changed the title feat(cli): add back tsconfigPath option to component.json feat(cli): add back tsConfigPath option to component.json Jul 5, 2025
@sadeghbarati sadeghbarati mentioned this pull request Jul 8, 2025
Open
2 tasks
@zernonia
Copy link
Member

Yo @sadeghbarati ! Thanks for adding this field back into the config. I wonder why this wasn't a request on actual ui.shadcn? Perhaps it would be better if we have the same monorepo support?

@sadeghbarati
Copy link
Collaborator Author

sadeghbarati commented Jul 24, 2025 •
edited
Loading

@zernonia

I think the monorepo CLI code is already here

We might need to remove the tsConfigPath option

But in Nuxt 4, we have an issue that this option may resolve it #1340

tsConfigPath is optional

Monorepo is too complicated people is just need to use normal directory for component registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zernonia zernonia Awaiting requested review from zernonia

Assignees
No one assigned
Labels
help wanted Extra attention is needed trigger: preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow tsconfig.json path to be configurable
2 participants
@sadeghbarati @zernonia