Skip to content

Add initial timeout to output_buffer.get_lines #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pesse opened this issue Feb 28, 2019 · 0 comments
Closed

Add initial timeout to output_buffer.get_lines #840

pesse opened this issue Feb 28, 2019 · 0 comments

Comments

@pesse
Copy link
Member

pesse commented Feb 28, 2019

In ut_output_table_buffer, when get_lines is called there should be a timeout thrown if no lines can be obtained after x seconds.

This is because if we request get_lines and don't run a corresponding TestRunner (as happening in utPLSQL/utPLSQL-cli#20), we only have the very big timeout of 4 hours in the reporters.
We should at least check that something is happening and act appropriately if not.
jgebal added a commit that referenced this issue Mar 5, 2019
@jgebal
ut_output_table_buffer will noe throw an exception on timeout.
a844b7b 
Default initial timeout was changed from 4 hours to 15 seconds.
All output reporters will now produce an extra leading line at the start of a test run.
Resolves #840
@jgebal jgebal mentioned this issue Mar 5, 2019
Merged
jgebal added a commit that referenced this issue Mar 5, 2019
@jgebal
ut_output_table_buffer will now throw an exception on timeout.
293e0f3 
Default initial timeout was changed from 4 hours to 15 seconds.
All output reporters will now produce an extra leading line at the start of a test run.
Resolves #840
@jgebal jgebal changed the title When calling Output_Buffer.get_lines there should be a timeout exception after x seconds if no content can be found Add initial timeout to output_buffer.get_lines Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pesse