Feature/1082 failure when comparing nested objects #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers issues of displaying wrong info in diff message for nested objects. Exclude object type from being part of the SQL generation.
…from XML extract causing to fail. Please see #1098 Resolve a situation where a more than two levels of nesting were causing ambiguity on the column name for hash. E.g. <OBJ1><FIRST><VAL><TEST> <OBJ1><SECOND><VAL><TEST> Was taking into hash consideration only parent.
This was
linked to
issues
Jan 26, 2022
simasch
approved these changes
Jan 26, 2022
…o fact that there was no name for collection columns as part of cursor only data type. Added extra tests.
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed! |
|
Let me have a deeper look into that PR before I approve it |
jgebal
requested changes
Jan 28, 2022
|
I've reviewed the PR. It addresses all 3 issues. |
|
Kudos, SonarCloud Quality Gate passed! |
jgebal
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue where code was failing on the nested objects due to "object" type being pulled into dynamic SQL as datatype to extract into.
Fixing issue when null value was passed to get_hash function causing compare to fail
Address a possible scenario when more than 2 levels of nesting for same objects caused ambiguity of the column name.
Closing #1082
Closing #1098
Closing #1083