Skip to content

fixed failed expectation source code line reporting because 12c repor… #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2017
Merged

fixed failed expectation source code line reporting because 12c repor… #332

merged 3 commits into from
Jun 1, 2017

Conversation

Pazus
Copy link
Member

@Pazus Pazus commented May 26, 2017

  1. fixed the issue when line and package of expectation failed was not reported correctly
  2. enchanted for 12.2 as call_stack is provided with procedure level detals

@coveralls
Copy link

coveralls commented May 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 91.708% when pulling 3830360 on Pazus:fix-expectation-reporting into a954a60 on utPLSQL:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.708% when pulling 3830360 on Pazus:fix-expectation-reporting into a954a60 on utPLSQL:develop.

jgebal
jgebal reviewed May 27, 2017
View reviewed changes
source/core/ut_expectation_processor.pkb Outdated
begin
l_caller_stack_line := regexp_substr( c_call_stack, c_expectation_search_pattern, 1, 1, 'm', 2);
--dbms_output.put_line(c_call_stack);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove commented code?

jgebal
jgebal reviewed May 27, 2017
View reviewed changes
Copy link
Member

@jgebal jgebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor comments.

tests/RunAll.sql Outdated
@@ -125,6 +125,7 @@ exec ut_coverage.coverage_start_develop();

@@lib/RunTest.sql ut_reporters/ut_coverage_sonar_reporter.AcceptsFileMapping.sql
@@lib/RunTest.sql ut_reporters/ut_coverage_sonar_reporter.BuildsSonarCoverageReport.sql
@@lib/RunTest.sql ut_reporters/ut_documentation_reporter.ProducesExpectedOutputs.sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe name the test: providesCorrectLineFromStacktrace?

@coveralls
Copy link

coveralls commented May 29, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 91.708% when pulling 1d6da23 on Pazus:fix-expectation-reporting into 1236007 on utPLSQL:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.708% when pulling 1d6da23 on Pazus:fix-expectation-reporting into 1236007 on utPLSQL:develop.

1 similar comment
@coveralls
Copy link

coveralls commented May 29, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 91.708% when pulling 1d6da23 on Pazus:fix-expectation-reporting into 1236007 on utPLSQL:develop.

@Pazus Pazus merged commit a9ffefa into utPLSQL:develop Jun 1, 2017
@Pazus Pazus removed the in progress label Jun 1, 2017
@Pazus Pazus deleted the fix-expectation-reporting branch July 15, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgebal jgebal jgebal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pazus @coveralls @jgebal