Added version_compatibility_check function to ut_runner
#464
Conversation
source/core/ut_utils.pkb
Outdated
| @@ -384,5 +384,18 @@ create or replace package body ut_utils is | |||
| commit; | |||
| end; | |||
|
|
|||
| function to_version(p_version_no varchar2) return t_version is | |||
There was a problem hiding this comment.
IMO this function should raise an exception with proper message if an illegal version-no string is provided.
source/api/ut_runner.pkb
Outdated
| @@ -43,6 +43,19 @@ create or replace package body ut_runner is | |||
| return ut_utils.gc_version; | |||
| end; | |||
|
|
|||
| function version_compatibility_check( a_requested varchar2, a_current varchar2 := null ) return boolean is | |||
There was a problem hiding this comment.
For boolean is not a SQL type but only PL/SQL (I guess it's still working that way) it might be more complicated to implement the Java request to this function, cause we can't just select version_compatibility_check(?) from dual
What do you think about return 0/1? Or adding another function, wrapping the boolean one and returning 0/1?
There was a problem hiding this comment.
Interesting observation.
We already have bool ->init and int->bool so the change will be quite simple.
I'm just wondering how would the select statement behave with overloaded functions (with boolan and integer return type) - will need to check
There was a problem hiding this comment.
You can't overload a funtion with a version which differes ony in return type.
test/ut_runner/test_ut_runner.pkb
Outdated
| ut.expect( ut3.ut_runner.version_compatibility_check('v3.0.0.0','v3.0.0.123') ).to_be_true; | ||
| ut.expect( ut3.ut_runner.version_compatibility_check('v3.0.0','v3.0.0.0') ).to_be_true; | ||
| end; | ||
|
|
There was a problem hiding this comment.
There should be tests to ensure version_compatibility_check behaves correctly (exception) when providing illegal version strings
…wing exception on version check, added tests for throwing exception.
# Conflicts: # test/install_and_run_tests.sh # test/install_tests.sql # test/ut_utils/test_ut_utils.pkb
|
I'm ok with the changes so lets wait for @pesse reviewal. |
source/core/ut_utils.pks
Outdated
| * | ||
| * @param a_version_no string representation of version in format vX.X.X.X where X is a positive integer | ||
| * @return t_version record with up to four positive numbers containing version | ||
| * @throws 20010 if passed version string is not matching version pattern |
source/api/ut_runner.pks
Outdated
| * @param a_requested requested utPLSQL version string | ||
| * @param a_current current utPLSQL version string, if null is passed, defaults to current framework version | ||
| * @return 1/0 1-true, 0-false | ||
| * @exception 20010 if passed version string is not matching version pattern |
Resolves #430
Added version parsing.
Changed value of
gc_versionvariable inut_utils