Moved CONTRIBUTING.md to project root and updated content #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pesse
requested changes
Aug 23, 2017
CONTRIBUTING.md
Outdated
| git fetch --all | ||
|
|
||
| # remove sub-direcotry containing master branch shallow copy | ||
| rm -rf utPLSQL/* |
There was a problem hiding this comment.
rm -rf utPLSQL
Otherwise it will lead to an error with following clone command
CONTRIBUTING.md
Outdated
| export UT3_TABLESPACE=users | ||
| export UT3_USER="UT3\$USER#" | ||
| export UT3_USER_PASSWORD=ut3 | ||
| export SQLCLI=sql |
There was a problem hiding this comment.
shouldn't that be
SQLCI=sqlplus
?
CONTRIBUTING.md
Outdated
| export ORACLE_PWD=oracle | ||
|
|
||
| .travis/install.sh | ||
| .travis/install_utplsql_release.sh |
There was a problem hiding this comment.
$ .travis/install_utplsql_release.sh
cd $UTPLSQL_DIR/source
.travis/install_utplsql_release.sh: line 5: cd: /source: No such file or directory
I guess exporting UTPLSQL_DIR is missing
CONTRIBUTING.md
Outdated
| execute immediate i.drop_orphaned_synonym; | ||
| end loop; | ||
| end; | ||
| / |
There was a problem hiding this comment.
Doesn't work inside 12c PDBs, raises ORA-65040: operation not allowed from within a pluggable database
There was a problem hiding this comment.
any alternative or any idea how to get this to work?
There was a problem hiding this comment.
Sorry I didn't come with a suggestion in the first place.
Problem is that it tries to drop SYS-Synonyms, which is not allowed for PDBS.
The following should do it:
begin
for i in (
select decode(owner,'PUBLIC','drop public synonym "','drop synonym "'||owner||'"."')|| synonym_name ||'"' drop_orphaned_synonym from dba_synonyms a
where a.table_owner <> 'SYS' and not exists (select null from dba_objects b where a.table_name=b.object_name and a.table_owner=b.owner )
) loop
execute immediate i.drop_orphaned_synonym;
end loop;
end;
…t standards. Updated `CONTRIBUTING.md` with additional info on project setup.
0b3445d to
fc8cd08
Compare
pesse
approved these changes
Aug 25, 2017
jgebal
commented
Aug 25, 2017
CONTRIBUTING.md
Outdated
| / | ||
| Cleanup of utPLSQL installation (call from your base repo directory). | ||
| ```bash | ||
| development/cleanup.sh |
…ttps://github.com/utPLSQL/utPLSQL into feature/contributing
… - so developers don't change it by accident. Changed directory name to `utPLSQL_latest_release` in travis to match the `template.env.sh` and updated `.gitignore` to prevent `env.sh` and `utPLSQL_latest_release` from getting committed.
5a85874 to
3fddfbd
Compare
…o develop (for now). Changed test_ut_utils to compile properly in Windows7 (UTF-8 using multi-byte emoji)
Added html coverage reporting to new tests.
Pazus
approved these changes
Aug 26, 2017
88127d8 to
681c1fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.