Adding cache and restructuring annotations #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notation text can be different depending on use case and it's not parsers responsibility to support all use-cases for annotation text. Added standalone/separated function `parse_annotation_params` that takes care of annotation text parsing.
…is covered with new tests.
…ations directory.
…n as output results. Reworked `ut_suite_manager` to operate on sorted collection for building ut_suite and it's tests. Adjusted `test_annotation_parser` to cover the refactoring.
Changed the way schema is scanned, so that all annotations/sources are scanned with single execution of a query. TODO - change the way annotations are parsed, so that we can scan for "floating" annotations. Annotations that are on top of suite, but associated with procedure, are not valid suite-level annotations. This is why the package `old_tests/helpers/test_reporters` was updated.
Added-back public procedure `ut_suite_manager.config_package` for testing purposes (example with huge ut package)
Added filtering of dba_source by test containing annotations. Added cardinality hint with scaling. Removed public procedure `config_package` - used only for one unit test. Fixed naming of procedures. Performance improvements on collections.
To test wrapped package we need to have an annotation-like text in it. This way the exception handler `when ex_package_is_wrapped` gets tested after adding source filters
Removed unused code from ut_meta_data. Improved code comments.
…ons_restructuring
8d87e96 to
8e26ed0
Compare
pesse
approved these changes
Oct 17, 2017
# Conflicts: # source/core/ut_utils.pkb # source/core/ut_utils.pks
…ons_restructuring
|
I see now that it's missing unit tests. |
|
Could you add a |
|
@Pazus I'm working on it now. Also refactoring the code a bit - better modularity and segregation of responsibility. |
* Added ability to build cache in `ut_annotation_manager.rebuild_annotation_cache` * Added ability to purge cache in `ut_annotation_cache_manager.purge_cache`
Added wrapper procedure `purge_cache` in `ut_annotation_manager` Changed tests to use wrapper procedure.
…ons_restructuring # Conflicts: # examples/demo_of_expectations/demo_equal_matcher.sql
Added wrapper procedures `purge_cache`, `rebuild_annotation_cache` in `ut_runner` Added tests for wrappers. Updated documentation for annotation cache calls.
|
@Pazus |
# Conflicts: # old_tests/ut_annotations/ut_annotations.parse_package_annotations.ParseAnnotationParamsWithBrackets.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old_testsfor ut_annotations - the functionality is covered with new tests.ut_suite_managerto operate on sorted collection for building ut_suite and it's tests.ut_annotation_parser.old_tests/helpers/test_reporterswas updated).Resolves #458