Skip to content

Fixed XML/HTML special characters in reportersand XUnit failures reporting #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2017
Merged

Fixed XML/HTML special characters in reportersand XUnit failures reporting #500

merged 4 commits into from
Oct 24, 2017

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Oct 24, 2017

Resolves #499
Resolves #487

Added calls to dbms_xml.convert in XML/HTML reporters.
Unified reporting of failures across reporters.
With that change, expectation results are only kept in ut_test for failed expectations.
XUnit reporter now reports also the line of the test where an expectation has failed.

@jgebal
Fixed XML/HTML special characters in reporters.
2a32620 
Resolves #499

Unified reporting of failures across reporters.
With that change, expectation results are only kept in `ut_test` for failed expectations.
XUnit reporter now reports also the line of the test where an expectation has failed.
Resolves #487
@jgebal jgebal added this to the v3.1.0 milestone Oct 24, 2017
@jgebal jgebal requested review from viniciusam, pesse and Pazus October 24, 2017 02:02
@ghost ghost assigned jgebal Oct 24, 2017
@ghost ghost added the in progress label Oct 24, 2017
pesse
pesse approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@pesse pesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work once again!

@Pazus Pazus merged commit 767b4bb into develop Oct 24, 2017
@ghost ghost removed the in progress label Oct 24, 2017
@jgebal jgebal deleted the feature/reporters_improvements branch October 24, 2017 21:35
@jgebal jgebal modified the milestones: v3.1.0, v3.0.4 Nov 3, 2017
@jgebal jgebal mentioned this pull request Jan 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pesse pesse pesse approved these changes

@viniciusam viniciusam Awaiting requested review from viniciusam

@Pazus Pazus Awaiting requested review from Pazus

Assignees

@jgebal jgebal

Labels
bugfix enhancement
Projects
None yet
Milestone
v3.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jgebal @pesse @Pazus